-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cached message state mixup #3278
Conversation
🚀 New react-contoso sample application deployed here |
1 similar comment
🚀 New react-contoso sample application deployed here |
packages/mgt-chat/src/statefulClient/StatefulGraphChatClient.ts
Outdated
Show resolved
Hide resolved
|
🚀 New react-contoso sample application deployed here |
Duplicating issue in this PR already tracked in #3030 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well. I don't get the duplicates on shuffling through chat lists.
Closes #3031
Closes #3032
PR Type
Bugfix
Description of the changes
Check for unique cached messages to prevent mixup, to fix issue in rapid chat changes resulting in incorrect chatID > chat message cache mapping.
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information
How to test: Checkout the branch and run the reac-chat app sample, test out changes.