Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only display selected person in people-picker single selection mode #3327

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Oct 1, 2024

Closes #3255

PR Type

Feature

Description of the changes

Remove input display once user is selected in single select mode in people-picker

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner October 1, 2024 14:58
Copy link

github-actions bot commented Oct 2, 2024

📖 The updated storybook is available here

Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Mnickii Mnickii merged commit b4d8c0c into main Oct 2, 2024
10 of 11 checks passed
@Mnickii Mnickii deleted the feat/single-select-display branch October 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

only display selected person after using the single select property in mgt-people-picker
2 participants