Fix source generation on Windows #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should finally make the package buildable on Windows as is. |
|
I used atomically blindly, did not care either way, and I just had to pick a value :-) Good to know that this causes problems on Windows, I will avoid in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildCommanddoes not work on Windows seemingly because of an SPM bug. I described the whole thing in Build command doesn't get executed on Windows swiftlang/swift-package-manager#6962. UsingprebuildCommandinstead fixes the issue.You don't have permissionerror. I suppose it's because generator executable doesn't have write permissions to the temporary directoryFoundationimplementation uses for atomic writes, since toggling offatomicallyfixed the issue for me. Not sure what benefit atomic writes can bring in context of code generator, so I disabled it for all platforms.