Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Swift 6.0 Tools Version #615

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

samdeane
Copy link
Contributor

@samdeane samdeane commented Nov 22, 2024

This is an experiment.

This changes swift-tools-version to 6.0, but then opts out all of the non-plugin targets from the Swift 6.0 language mode (for now).

There is no way to opt out for plugins, so they are updated (the updates are fairly trivial).

Partly I did this to see whether forcing the tools version to 6.0 helped with any of the Windows build problems.

It does also have the advantage that we can migrate targets to Swift 6.0 one at a time, when the time comes.

Obviously this change would force a dependency on the Swift 6.x toolchain. That may be a good thing, if it reduces the need to cope with legacy compiler weirdness (eg windows compiler features lagging behind).

Package.swift Outdated Show resolved Hide resolved
@samdeane samdeane marked this pull request as ready for review November 27, 2024 15:20
@migueldeicaza
Copy link
Owner

I am happy to merge this, I do not have any objections to it.

You said it was experimental, do you have any concerns about it?

I have the patches updated and merged locally.

@samdeane
Copy link
Contributor Author

I don't think there are any concerns if you're happy for people to need a Swift 6.0 toolchain.

@samdeane
Copy link
Contributor Author

One thought - I wonder if the version number of swift-syntax could/should be bumped up?

@samdeane
Copy link
Contributor Author

One thought - I wonder if the version number of swift-syntax could/should be bumped up?

I tried this and it seemed to go ok, with only minimal changes required. I'm not sure if there are any other implications.

I rebased the branch as a result, but you said you already have an updated/merged patch locally so if it's easier to go with that, I can always re-submit the extra bit as a different PR -- just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants