This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Heimdall 1 #22
Open
Heimdall 1 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heimdall.application/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| <version>2.11.1</version> |
There was a problem hiding this comment.
version to be added in properties tag
aakash17kc
commented
Jun 29, 2020
| reqEntity.addTextBody("channel", slackChannelInfo.channelName).addTextBody("as_user", "true") | ||
| .addTextBody("text", slackMessageInfo.testExecutionInfo.toString()); | ||
| final String generatedFileName = Files.write(Paths.get(ATTACHMENT_FILE_NAME), | ||
| buildResultDto.failedTestDescription.toString().getBytes()).normalize().toAbsolutePath() |
There was a problem hiding this comment.
I'll update the code for failedtestcount == 0
|
Can you resolve the conflicts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added email notification.
Removed parent pom.
Removed Jenkins url from code(was hardcoded).
Renamed packages.
Gson was replaced with Jackson.
Updated Readme for new code.
Updated properties file with email properties