-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible_mitogen: Handle templated ansible_ssh_user. #1147
Conversation
f9e336f
to
5295667
Compare
After reviewing #1145, I decided to prune this PR down to handling the templated username only. |
Thank you, I'll review your code shortly. The single test failure is due to #1058.
I've recently moved the test runner from Azure to GitHub, and I'm stilling learning the finer details for who has permission to do what. |
5295667
to
6053e1b
Compare
Hold off on answering the previous questions. Your push at 0803 UTC retriggered the CI. I'll update the questions, based on the outcome. |
Before I triggered the next CI run, I went through each of the questions you asked.
There was no "Re-run all jobs" button in the top-right nor anywhere else that I could see.
There is no "Re-run jobs" button in the dropdown. The only available option was "Create status badge".
Understood. I'll wait for your update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is probably correct, but it needs tests that cover the templating. I'm still trying to find a good structure for these tests.
For now, if you feel confident, please use 551690e#diff-3ec47820fbd7f6bf8db852de80857cdce3f6aec7f76c5a452c93923501dc23ac as a template. Otherwise if you prefer I'll add a commit to this PR containing the new tests
Co-authored-by: Alex Willmer <alex@moreati.org.uk>
If you already have a test case in mind then feel free to modify this branch as you see fit. I can try writing some test cases after 2024-10-09 01:00 UTC. |
At the time you looked were there any failed checks? |
There were two failed checks: one for an intermittently failing test and one for the aggregate check. |
Rats. I'd been hoping that GitHub Actions would be easier re-run for third-party contributers. I'll see if there's a GHA equivalent of "/AzurePipelines run" |
Although it's not precisely the same thing, you may be able to trigger a Github Actions workflow based on a |
This reads the become username from the `become_user` attribute of the play context, to the `"become_user"` option of the loaded become plugin. This has been supported by vanilla Ansible since Ansible 2.10 (ansible-base 2.10). To support this I've also switched from using the `play_context.become` (a bool), to `connection.become` (an instance of the appropriate) become plugin. New tests have been added, modelled on those for templated connection parameters (see mitogen-hq#1147, mitogen-hq#1153, mitogen-hq#1159). See - ansible/ansible@480b106 refs mitogen-hq#1083 Co-authored-by: mordek <m.pirog@bonasoft.pl>
This PR expands the evaluation of templates in inventory/group variables to include
ansible_ssh_user
.Please let me know if it requires any changes.
Fixes: #1116