Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to SDXL accuracy output, submission preprocessor, fixes #1938 #1948

Merged
merged 46 commits into from
Dec 4, 2024
Merged

Fixes to SDXL accuracy output, submission preprocessor, fixes #1938 #1948

merged 46 commits into from
Dec 4, 2024

Conversation

arjunsuresh
Copy link
Contributor

@arjunsuresh arjunsuresh commented Nov 21, 2024 •
edited
Loading

Also, makes the SDXL reference implementation thread safe - fixes #1917

arjunsuresh and others added 23 commits October 31, 2024 14:55
@arjunsuresh
Update generate_final_report.py
d8f0d7e
@arjunsuresh
Merge branch 'master' into dev
390a8cb
@arjunsuresh
Fix sdxl (#1911)
6b1a0f8 
* Fix typo in fid_score.py, fail_safe for SDXL short runs

* [Automated Commit] Format Codebase

* Fix typo in fid_score.py, fail_safe for SDXL short runs

* Fix dlrmv2 reference implementation | Update run_local.sh
@arjunsuresh
Fixes for filtering invalid results
a4ba51f
@arjunsuresh
Merge branch 'master' into dev
7097ef5
@arjunsuresh
Merge 7097ef5 into d3c01ed
190ee41
@arjunsuresh
[Automated Commit] Format Codebase
451b310
@arjunsuresh
Update preprocess_submission.py
4c109ea
@arjunsuresh
Added an option to pass in sample_ids.txt for SDXL accuracy check
40c1fe0
@arjunsuresh
Merge 40c1fe0 into d3c01ed
2a61df9
@arjunsuresh
[Automated Commit] Format Codebase
89a2ffe
@arjunsuresh
Update accuracy_coco.py
69ffdc0
@arjunsuresh
Merge 69ffdc0 into d3c01ed
76b703b
@arjunsuresh
[Automated Commit] Format Codebase
d1d642e
@arjunsuresh
Fix typo
8d3b8ab
@arjunsuresh
Not use default for sample_ids.txt
b09b1ef
@arjunsuresh
Merge branch 'master' into dev
857494f
@arjunsuresh
Update requirements.txt (#1907)
df5049d 
Updating the pip packages
@arjunsuresh
Fix preprocess_sudbmission for a bug
a7e8c8a
@arjunsuresh
Fix conflict
213c239
@arjunsuresh
Update submission_checker.py | Removed TEST05
8915a90
@arjunsuresh
Merge branch 'master' into dev
36d5b74
@arjunsuresh
Fix to SDXL accuracy output
da9e6bb
@arjunsuresh arjunsuresh requested a review from a team as a code owner November 21, 2024 18:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arjunsuresh arjunsuresh changed the title Fixes to SDXL accuracy output Fixes to SDXL accuracy output, submission preprocessor, fixes #1938 Nov 22, 2024
@mrmhodak
Copy link
Contributor

mrmhodak commented Dec 3, 2024

@pgmpablo157321 to review

@pgmpablo157321
Copy link
Contributor

@arjunsuresh Regarding the format.yml action, it isn't working on forked pull request. But I see that this is removing it completely. Should we fix it? Otherwise LGTM, I am ok merging this and opening an issue for this

@arjunsuresh
Copy link
Contributor Author

Thank you @pgmpablo157321 for reviewing. I just added the GH action file for the push (instead of on PR) - I believe I had deleted it by mistake earlier.

@pgmpablo157321 pgmpablo157321 merged commit b6f5a34 into master Dec 4, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgmpablo157321 pgmpablo157321 pgmpablo157321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDXL: index 21 is out of bounds for dimension 0 with size 21
4 participants
@arjunsuresh @mrmhodak @pgmpablo157321 @mlcommons-bot