Skip to content

Commit

Permalink
Merge pull request #43 from modcloth/prefer-yes-no
Browse files Browse the repository at this point in the history
Prefer yes/no to True/False in most cases
  • Loading branch information
Rafe Colton committed Oct 6, 2014
2 parents ac93071 + 693f85f commit 6ed3d2d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ modcloth_app_docker_port: 3000
# ensures the directory on the host will be created
modcloth_app_docker_volumes: []
# Example:
# - { host: /var/lib/redis, container: /var/lib/redis, directory: true }
# - { host: /var/lib/redis, container: /var/lib/redis, directory: yes }

# adds the --link option for `docker run` to the templates
modcloth_app_docker_link: []
Expand Down
2 changes: 1 addition & 1 deletion defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ modcloth_app_docker_port: 3000
# ensures the directory on the host will be created
modcloth_app_docker_volumes: []
# Example:
# - { host: /var/lib/redis, container: /var/lib/redis, directory: true }
# - { host: /var/lib/redis, container: /var/lib/redis, directory: yes }

# adds the --link option for `docker run` to the templates
modcloth_app_docker_link: []
Expand Down
14 changes: 7 additions & 7 deletions tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
- name: get local facts
sudo: false
sudo: no
connection: local
modcloth_app_facts:
github_token={{ github_token }}
Expand All @@ -9,18 +9,18 @@
changed_when: False

- name: render hipchat deployment html
sudo: false
sudo: no
connection: local
template:
src=hipchat_notification.frag.html.j2
dest={{ modcloth_app_hipchat_html }}
mode=0644
changed_when: False
when: hipchat_token != "" and hipchat_room != ""
ignore_errors: True
ignore_errors: yes

- name: notify hipchat deploy started
sudo: false
sudo: no
connection: local
hipchat:
token: "{{ hipchat_token }}"
Expand All @@ -30,7 +30,7 @@
color: yellow
changed_when: False
when: hipchat_token != "" and hipchat_room != ""
ignore_errors: True
ignore_errors: yes
run_once: yes

- name: write etc default file
Expand All @@ -57,7 +57,7 @@
register: modcloth_app_type_long_running

- name: notify hipchat deploy complete
sudo: false
sudo: no
connection: local
hipchat:
token: "{{ hipchat_token }}"
Expand All @@ -67,5 +67,5 @@
color: green
changed_when: False
when: hipchat_token != "" and hipchat_room != ""
ignore_errors: True
ignore_errors: yes
run_once: yes

0 comments on commit 6ed3d2d

Please sign in to comment.