Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @web/test-runner-visual-regression to v0.6.1 #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Westbrook
Copy link
Member

fixes #354

Do some extra work to prepare for the latest version of the visual regression plugin.

@Westbrook Westbrook force-pushed the westbrook/visual-regression branch 2 times, most recently from 2cfd8c2 to 4d84066 Compare July 8, 2021 02:35
@Westbrook Westbrook force-pushed the westbrook/visual-regression branch from 4d84066 to 3e39a26 Compare July 8, 2021 02:38
@@ -10,6 +10,7 @@
"scripts": {
"start": "web-dev-server --open demo/ --node-resolve",
"start:watch": "web-dev-server --open demo/ --node-resolve --watch",
"pretest": "web-test-runner test/**/*.test.js --coverage --node-resolve --update-visual-baseline",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously failed because there were no baseline screenshots. We should probably make a pass at how you could cache screenshots from Actions, but I don't use them in my own projects, so I don't know anything about them... this builds a cache and then tests it, which is similar for this context.

@Westbrook Westbrook requested a review from LarsDenBakker July 8, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant