Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Remove String StringRef dependencies #3870

Open
wants to merge 5 commits into
base: nightly
Choose a base branch
from
Open

[stdlib] Remove String StringRef dependencies #3870

wants to merge 5 commits into from

Conversation

martinvuyk
Copy link
Contributor

Remove String StringRef dependencies

@martinvuyk
Remove String StringRef dependencies
52c5f47 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk requested a review from a team as a code owner December 11, 2024 19:41
JoeLoser
JoeLoser approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 13, 2024
@martinvuyk
undo delete _from_bytes
df6245d 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
Merge remote-tracking branch 'upstream/nightly' into remove-string-st…
1559c35 
…ringref-dependencies
@JoeLoser
Copy link
Collaborator

!sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvuyk @JoeLoser @modularbot