Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Make String and StringLiteral .splitlines() return List[StringSlice] #3894

Open
wants to merge 8 commits into
base: nightly
Choose a base branch
from
Open

[stdlib] Make String and StringLiteral .splitlines() return List[StringSlice] #3894

wants to merge 8 commits into from
+118 −68

Conversation

martinvuyk
Copy link
Contributor

@martinvuyk martinvuyk commented Dec 17, 2024 •
edited
Loading

Make String and StringLiteral .splitlines() return List[StringSlice].

part of #3879. This is also making the to_string_list() helpers public

personal note: I'd like to just delete the tests for StringLiteral and String since IMO they are redundant now that they just wrap StringSlice.splitlines()

@martinvuyk
Make String and Stringliteral splitlines return List[StringSlice]
f9f37a7 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk requested a review from a team as a code owner December 17, 2024 19:25
@martinvuyk martinvuyk marked this pull request as draft December 17, 2024 19:32
@martinvuyk
bring over the tests form string slice
8cae7a9 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
bring over the tests form string slice
81ba2c1 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
fix missing import
01dc2d4 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk marked this pull request as ready for review December 18, 2024 01:45
@ConnorGray ConnorGray self-assigned this Dec 19, 2024
@ConnorGray
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 19, 2024
@martinvuyk
add suggestions by @ConnorGray
b3f4924 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk
Merge remote-tracking branch 'upstream/nightly' into make-splitlines-…
4c1dc2a 
…return-list-stringslice
@martinvuyk
add var to _to_string_list implementation
8fc5fd9 
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@ConnorGray
Copy link
Collaborator

!sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorGray ConnorGray ConnorGray left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ConnorGray ConnorGray

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvuyk @ConnorGray @modularbot