fix UI test failure on NPP 8.3.3 (handle nul end)

the oldest NPP version the UI tests were tried on previously
    was 8.3.3.
The tests previously passed on NPP 8.4.2 but failed on 8.3.3,
    but now they all pass on 8.3.3 (not tested on anything
    between those two, nor on anything earlier than 8.3.3).

The test failures were due to issues with requesting
    only n bytes of a document with n + 1 bytes after factoring
    in the NUL terminator.

CHANGELOG.md

@@ -57,6 +57,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 1. Eliminated plugin crash when attempting to open the [regex search form](/docs/README.md#regex-search-form) after it had been closed.
+2. Some UI test failures (and probably related weirdness in public API) on older NPP versions
 
 ## [6.0.0] - 2023-12-13
 

JsonToolsNppPlugin/Forms/TreeViewer.cs

@@ -1064,7 +1064,7 @@ public static bool LengthOfStringInRegexMode(JNode[] nodes, char delim, char quo
                     int nodepos = jnode.position;
                     if (documentText is null)
                         documentText = selectionEnd < 0
-                            ? Npp.editor.GetText(Npp.editor.GetLength() + 1)
+                            ? Npp.editor.GetText()
                             : Npp.GetSlice(selectionStart, selectionEnd);
                     int utf8Extra = 0;
                     for (; startIndex < documentText.Length && startIndex + utf8Extra < nodepos; startIndex++)

JsonToolsNppPlugin/Main.cs

@@ -964,7 +964,7 @@ public static void DumpSelectedTextAsJsonString()
             var selections = SelectionManager.GetSelectedRanges();
             if (SelectionManager.NoTextSelected(selections))
             {
-                string text = Npp.editor.GetText(Npp.editor.GetLength());
+                string text = Npp.editor.GetText();
                 JNode textNode = new JNode(text);
                 PrettyPrintJsonInNewFile(textNode);
             }
@@ -1020,7 +1020,7 @@ public static void DumpSelectedJsonStringsAsText()
         public static string TryGetSelectedJsonStringValue(int start = -1, int end = -1)
         {
             string text = start < 0 || end < 0
-                ? Npp.editor.GetText(Npp.editor.GetLength())
+                ? Npp.editor.GetText()
                 : Npp.GetSlice(start, end);
             try
             {

JsonToolsNppPlugin/PluginInfrastructure/IScintillaGateway.cs

@@ -909,12 +909,12 @@ public interface IScintillaGateway
         unsafe void SetText(string text);
 
         /// <summary>
-        /// Retrieve all the text in the document.
+        /// Retrieve all the text in the document (or the first length chars of the document).
         /// Returns number of characters retrieved.
         /// Result is NUL-terminated.
         /// (Scintilla feature 2182)
         /// </summary>
-        unsafe string GetText(int length);
+        unsafe string GetText(int length = -1);
 
         /// <summary>Retrieve the number of characters in the document. (Scintilla feature 2183)</summary>
         int GetTextLength();

JsonToolsNppPlugin/PluginInfrastructure/ScintillaGateway.cs

@@ -1764,8 +1764,10 @@ public unsafe void SetText(string text)
         /// Result is NUL-terminated.
         /// (Scintilla feature 2182)
         /// </summary>
-        public unsafe string GetText(int length)
+        public unsafe string GetText(int length = -1)
         {
+            if (length == -1)
+                length = GetLength() + 1;
             byte[] textBuffer = new byte[length];
             fixed (byte* textPtr = textBuffer)
             {

JsonToolsNppPlugin/Properties/AssemblyInfo.cs

@@ -28,5 +28,5 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("6.0.0.9")]
-[assembly: AssemblyFileVersion("6.0.0.9")]
+[assembly: AssemblyVersion("6.0.0.10")]
+[assembly: AssemblyFileVersion("6.0.0.10")]

JsonToolsNppPlugin/Tests/UserInterfaceTests.cs

@@ -110,7 +110,7 @@ public static bool ExecuteFileManipulation(string command, List<string> messages
                 break;
             case "compare_text":
                 var correctText = (string)args[0];
-                string gotText = Npp.editor.GetText(Npp.editor.GetLength());
+                string gotText = Npp.editor.GetText();
                 if (correctText != gotText)
                 {
                     messages.Add($"FAIL: expected text\r\n{correctText}\r\nGOT\r\n{gotText}");