Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved --path handling in CLI #64 fix ef and dim selection #65 #66

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

iQuxLE
Copy link
Member

@iQuxLE iQuxLE commented Aug 24, 2024

Not including --path when indexing cause a downstream error for the DuckDB implementation.
This handles the cases better as discussed in #64

Updating vocab, get_ef and get_embedding_dimension

@iQuxLE iQuxLE requested a review from cmungall August 24, 2024 02:15
@iQuxLE iQuxLE changed the title improved --path handling in CLI #64 fix ef and dim selection # improved --path handling in CLI #64 fix ef and dim selection #65 Aug 24, 2024
@iQuxLE iQuxLE merged commit 32fa049 into monarch-initiative:main Aug 27, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant