Add malacards to emc pipeline #722
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
reviewed
Dec 16, 2024
| @@ -751,6 +752,16 @@ $(EXTERNAL_CONTENT_DIR)/mondo-otar-subset.robot.tsv: | |||
| $(EXTERNAL_CONTENT_DIR)/mondo-medgen.robot.tsv: | |||
| wget "https://github.com/monarch-initiative/medgen/releases/latest/download/medgen-xrefs.robot.template.tsv" -O $@ | |||
|
|
|||
| ###### MalaCards ######### | |||
There was a problem hiding this comment.
Cool. Just looking at this preliminarily. See if you can re-request or tag me again to review when it is undrafted and ready.
I like their website and how the entry pages are put together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MalaCards (by GeneCards) as EMC to Mondo Ingest.
Overview
This PR:
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Yes
Await further instructions from malacard team before proceeding