fix(Dropdown): aria labels not passed to dropdown menu #2707
Conversation
| @@ -30,7 +31,7 @@ const Menu = ({ children, Renderer, selectProps, dropdownMenuWrapperClassName, i | |||
| return ( | |||
| <components.Menu | |||
| {...props} | |||
| innerProps={{ ...props.innerProps, onScroll: props.onScroll }} | |||
| innerProps={{ ...rendererProps.innerProps }} | |||
There was a problem hiding this comment.
this is breaking, isn't it?
There was a problem hiding this comment.
wait, who is ...props.innerProps? it seem like this attr doesn't even exist on props of menu
There was a problem hiding this comment.
Why would it be breaking? Now there is a bug that the props.innerProps + scroll is passed but the id, role and aria-label are being ignored, so I just added them
There was a problem hiding this comment.
but is props.innerProps even a thing? where does it come from?
There was a problem hiding this comment.
and if it is a thing, and it can contain id, role, aria-label, it means it's breaking since it overrides this change now always override those 3.
There was a problem hiding this comment.
It comes from line 12, where the additional props are set
There was a problem hiding this comment.
but the Menu component never gets a prop called inlineProps
There was a problem hiding this comment.
oh it's a "react-select" prop which is automatically passed, I see now
we need to make sure inlineProps never includes one of those three
if it does, even in edge scenarios, it is kind of breaking
There was a problem hiding this comment.
Seem like it does contain it
https://react-select.com/props#replacing-components
There was a problem hiding this comment.
Is it under our control? is it always not containing it in current scenario? or consumers can somehow pass something to our Dropdown causing it to pass innerProps with different role, id, and aria-label?
https://monday.monday.com/boards/3532714909/views/80492480/pulses/8085300950