-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Artifactory for image registry #911
Conversation
To avoid "not implemented" error referenced in mongodb/mongo-c-driver#1794
To agree with Evergreen distro best practices: "If selecting Ubuntu, for example, prefer a 22.04 (or 20.04) distro version over 18.04 if you can."
Docker distros are updated to remove
I expect this is due to the // This only has an effect when the Target contains at least one `CACHE /my/directory` command. Filed MONGOCRYPT-747 to track removing workaround. Latest changes verified by this patch build. |
* replace dockerhub references with artifactory * install `make` to build clang-format * remove ubuntu2004 from docker distros. * Avoids "not implemented" error referenced in mongodb/mongo-c-driver#1794 * replace ubuntu1804 with ubuntu2204 in docker distros * Agrees with Evergreen distro best practices. * pass `--persist-build=false` to avoid internal use of Docker Hub
This PR is intended to address rate-limiting errors pulling from dockerhub causing task failures on Evergreen. Example:
DEVPROD-12779 notes:
Running
docker pull artifactory.corp.mongodb.com/dockerhub/<DOCKER_IMAGE>:<DOCKER_TAG>
appears to pull and add the image to the artifactory registry. DEVPROD-12779 also notes:Getting credentials is tracked in DRIVERS-3047.
As an added fix, the
check-format
target is updated to installmake
to address an observed error:Verified with this patch build