Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format script #918

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix format script #918

merged 3 commits into from
Dec 4, 2024

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Nov 22, 2024

Summary

  • Update formatting script for Python 3.12
  • Add CONTRIBUTING.md
  • Relocate design rationale from README.md to integrating.md

Details

The formatting script is updated to address an observed error on Python 3.12:

$ bash etc/format-all.sh
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'pkg_resources'

The error comes from this check:

run_python -c 'import pkg_resources; pkg_resources.require("pipx>=0.17.0,<2.0")'

pkg_resources is removed in Python 3.12. I expect that check is not strictly needed. This check has been removed.

A MONGOCRYPT_PYTHON environment variable is added to specify an override python version. This is documented in a new CONTRIBUTING.md document.

@kevinAlbs kevinAlbs marked this pull request as ready for review November 22, 2024 18:32
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit aa0397a into mongodb:master Dec 4, 2024
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants