MONGOCRYPT-755 Implement StrEncode #928
Draft
+1,047
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwee
requested changes
Jan 2, 2025
| mc_substring_set_t *substring_set; | ||
| char *exact; | ||
| size_t exact_len; | ||
| } mc_str_encode_sets_t; |
src/mc-text-search-str-encode.c
Outdated
|
|
||
| mc_str_encode_sets_t mc_text_search_str_encode(const mc_FLE2TextSearchInsertSpec_t *spec) { | ||
| // TODO MONGOCRYPT-759 Implement and use CFold | ||
| uint32_t unfolded_len = spec->len; |
There was a problem hiding this comment.
Add BSON_ASSERT_PARAM(spec) before this
src/mc-text-search-str-encode.c
Outdated
| sets.substring_set = NULL; | ||
| // Base string is the folded string plus the 0xFF character | ||
| sets.base_string = make_base_string_for_str_encode(folded_str, folded_len); | ||
| sets.base_len = spec->len + 1; |
There was a problem hiding this comment.
Suggested change
| sets.base_len = spec->len + 1; | |
| sets.base_len = folded_len + 1; |
Prefer using folded/unfolded_len over spec->len.
src/mc-text-search-str-encode.c
Outdated
| } | ||
| // Exact string is always the first len characters of the base string | ||
| sets.exact = sets.base_string; | ||
| sets.exact_len = spec->len; |
There was a problem hiding this comment.
Suggested change
| sets.exact_len = spec->len; | |
| sets.exact_len = folded_len; |
same here
| // TODO MONGOCRYPT-759 This helper only exists to test folded_len != unfolded_len; make the test actually use folding | ||
| mc_str_encode_sets_t mc_text_search_str_encode_helper(const mc_FLE2TextSearchInsertSpec_t *spec, | ||
| uint32_t unfolded_len) { | ||
| const char *folded_str = spec->v; |
There was a problem hiding this comment.
add BSON_ASSERT_PARAM(spec) before this
| static mc_substring_set_t *generate_substring_tree(const char *base_str, | ||
| uint32_t folded_len, | ||
| uint32_t unfolded_len, | ||
| const mc_FLE2SubstringInsertSpec_t *spec) { |
There was a problem hiding this comment.
This function also needs beta and gamma parameters which are the code-point lengths, not the byte length.
There was a problem hiding this comment.
done (folded codepoint len is inside the base string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.