Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Adds fullpaths to dylibs in libglib and pango to fix monterey linking #1075

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

netonjm
Copy link
Contributor

@netonjm netonjm commented Nov 24, 2021

New MacOS Monterey is not correctly resolving dylib locations when dllmap configuration is not specifying full paths, this makes VS4Mac use libcairo-2.dll from a dependency of a installed library in Hombrew.

A workaround was set full path to libcairo-2 and this fixed the problem.

@netonjm netonjm self-assigned this Nov 24, 2021
@netonjm netonjm requested review from sevoku and Therzok November 24, 2021 12:43
@HinTak
Copy link

HinTak commented Nov 24, 2021

I don't think the path in dll.config has got anything to do with monterey linking? I think it is better to let the linker decide (to allow embedded and relocated usage)

@netonjm
Copy link
Contributor Author

netonjm commented Nov 24, 2021

I don't think the path in dll.config has got anything to do with Monterey linking? I think it is better to let the linker decide (to allow embedded and relocated usage)

Just to add some context, after the Monterey update, the linking is failing to get correct paths in some users with Homebrew installed and packages with libcairo and libglib dependencies. The problem is that the linking is incorrectly deciding the directories to look for, instead of using the Mono folder as the first option, it uses the libraries within Homebrew, and this causes an NRE at startup. That is a workaround to avoid this scenario when starting, but I agree it is something that should be solved in a general way in MONO.

Mono runtime will resolve the variable to its own lib path automatically.

See #1075 (review)
sevoku added a commit that referenced this pull request Dec 2, 2021
Mono runtime will resolve the variable to its own lib path automatically.

See #1075 (review)
@Therzok
Copy link
Contributor

Therzok commented Dec 2, 2021

Funny thing is that it was a guess :D

@sevoku
Copy link
Member

sevoku commented Dec 2, 2021

I have merged the changes to d16-10 branch, we're using now for the next VSMac 8.10 release. I don't think this needs to be in main and I agree with @HinTak about linker. Converting this to a draft for now.

@sevoku sevoku marked this pull request as draft December 2, 2021 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants