This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
[Gtk] Adds EditingFinished event to cell renderers #914
+174
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netonjm
force-pushed
the
gridview-editable
branch
from
2df379b to
9666525
Compare
|
Should we pass over the old/new value in the event args? |
|
This happens when the value is set in your model, then you can check it here, but yes, we can include it in the args |
Therzok
approved these changes
Jan 29, 2019
|
The reason the event args are used is so event handlers do not have to query. In example, looking up the value in a store or looking up which row changed can be costly, and if 2 event handlers are subscribed, we do potentially expensive lookups instead of doing a cheap one at eventargs construction timem |
|
It's a good reason to include it 👍 |
slluis
approved these changes
Jan 31, 2019
sevoku
approved these changes
Feb 10, 2019
|
@netonjm are you going to add the event args? This should fix #795 and we could also fix mono/monodevelop#4075 |
sevoku
approved these changes
Feb 11, 2019
sevoku
reviewed
Feb 11, 2019
sevoku
approved these changes
Feb 11, 2019
|
LGTM now! cc @slluis for the last API change |
|
We should rebase and merge this. Stumbled upon mono/monodevelop#4075 |
netonjm
force-pushed
the
gridview-editable
branch
from
fba46ff to
a49a912
Compare
netonjm
force-pushed
the
gridview-editable
branch
from
acbef23 to
6dd9512
Compare
netonjm
force-pushed
the
gridview-editable
branch
from
6dd9512 to
f75231a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows handle the event when the edition has finished. It's very useful to get real values from the ListStore.
I didn't implemented the Cocoa side because there are no implementation, but this can be added in the future.