Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tajik localization in prod #15784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janbrasna
Copy link
Contributor

One-line summary

Adds tg to allowed locales in settings to stop 404ing in prod.

Significant changes and points to review

Following up from #15021, this is pending approval from l10ns.

This locale is still listed on the global root home page and offered to crawlers, but returns 404 as it is not explicitly allowed. (The reason is explained in both the previous PR and the linked issue.)

After an inquiry during the previous PR into the commitment of keeping Tajik version of wwwmo up to date, the community got very active the following months, and went from ~20% to currently 60%+ of translated content, with the usual key pages as home, products, browsers, vpn etc. above the threshold for enabling the locale. So the question is, whether also the Tajik locale wouldn't be a worthwhile addition, given its recent activity.

Issue / Bugzilla link

#15010

Testing

(in prod mode, with Debug=False & Dev=False)
http://localhost:8000/ (with Accept-Locale unset)
http://localhost:8000/404-locale/
http://localhost:8000/tg/

@janbrasna janbrasna requested a review from a team as a code owner December 19, 2024 22:59
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (12806d5) to head (bca64f0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15784      +/-   ##
==========================================
- Coverage   79.07%   79.07%   -0.01%     
==========================================
  Files         160      160              
  Lines        8360     8359       -1     
==========================================
- Hits         6611     6610       -1     
  Misses       1749     1749              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant