Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force consistent header height #15790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janbrasna
Copy link
Contributor

One-line summary

Refreshed pages have different defaults affecting also nav elements, making shifts in layout visible when navigating to older pages. This sets the base var explicitly to the header components to not inherit any other value.

Significant changes and points to review

Both the desktop and mobile nav inconsistencies caused by differing line-height as captured in the tracking issue are resolved here by using the "taller" version as that seems to be better aligned in general.

Issue / Bugzilla link

Fixes #15788

Testing

/about/ ⇄ /products/

@janbrasna janbrasna requested a review from a team as a code owner December 24, 2024 00:45
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (c8ac92f) to head (0fd6981).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15790      +/-   ##
==========================================
+ Coverage   79.07%   79.10%   +0.03%     
==========================================
  Files         160      160              
  Lines        8359     8371      +12     
==========================================
+ Hits         6610     6622      +12     
  Misses       1749     1749              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header moves between pages
1 participant