Fix RTL pages with firefox-app-store banner #15793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Clips any overflow so that page width doesn't change.
(Fixes broken RTL product pages on mobile chromium.)
Significant changes and points to review
Tried to trace the viewport width to something moving far left, e.g. "image-replaced" or "visually-hidden" -9999px etc. but wasn't able to find the actual culprit (to perhaps change that to bidi or inline-start syntax). This instead makes sure the banner is contained in its box for good measure, which also gets the job done, with not much risk of breaking somewhere.
Issue / Bugzilla link
Resolves #15715
Testing
(webkit+chromium, banner displayed i.e. not dismissed and on detected mobile device etc.)
http://localhost:8000/ar/firefox/
http://localhost:8000/ar/firefox/mobile
http://localhost:8000/ar/firefox/focus
http://localhost:8000/ar/firefox/android
http://localhost:8000/ar/firefox/ios