Add linear model statistic with covariate adjustment #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewilli
approved these changes
May 21, 2024
jetstream/tests/test_statistics.py
Outdated
| assert rel_results.lower > rel_results_unadj.lower | ||
| assert rel_results.upper < rel_results_unadj.upper | ||
|
|
||
| def test_linear_model_mean_covariate_bad_period(self): |
There was a problem hiding this comment.
Could test all of the bad ones with @pytest.mark.parametrize, and then add a test of the good ones too the same way.
Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
|
All requested changes made, just waiting on the last test run to finish. Going to add to the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document implements the solution from this proposal.