Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Solaris support #45

Merged
merged 25 commits into from
Dec 17, 2024
Merged

feat: Solaris support #45

merged 25 commits into from
Dec 17, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Nov 21, 2024

Because libc on Solaris misses most of the needed symbols, this pulls them in via bindgen also for the other BSDs. This has the side effect of removing the dependency on a relatively recent libc (= newer than what Gecko requires).

Also some refactoring to the VM CI checks as I was adding Solaris support there.

Drop in coverage is mostly because llvm-cov is not available on Solaris.

Base automatically changed from feat-from-routing to main November 21, 2024 13:33
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 63.23529% with 25 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (7ddfc13) to head (2c30648).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bsd.rs 62.12% 20 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   88.78%   86.28%   -2.50%     
==========================================
  Files           5        5              
  Lines         517      554      +37     
  Branches      517      554      +37     
==========================================
+ Hits          459      478      +19     
- Misses         34       48      +14     
- Partials       24       28       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert marked this pull request as ready for review December 2, 2024 11:24
@larseggert
Copy link
Collaborator Author

Do we want this as part of 0.2.3?

@mxinden
Copy link
Collaborator

mxinden commented Dec 2, 2024

Do we want this as part of 0.2.3?

I don't see why not. Loosening the libc requirement is not a breaking change. Am I missing something?

@larseggert
Copy link
Collaborator Author

I don't see why not. Loosening the libc requirement is not a breaking change. Am I missing something?

No, you're not missing anything. I thought including this might make landing 0.2.3 in gecko easier, due to the lift of the restriction on lib.

Will wait for @martinthomson to give this a review.

src/bsd.rs Outdated Show resolved Hide resolved
src/bsd.rs Show resolved Hide resolved
src/bsd.rs Outdated Show resolved Hide resolved
src/bsd.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what my review is worth, this looks good to me.

@larseggert
Copy link
Collaborator Author

@mxinden is there a way to test whether the libc version requirement is resolved by this?

@mxinden
Copy link
Collaborator

mxinden commented Dec 3, 2024

@larseggert you should be able to run something along the lines of:

cargo update -p libc --precise 0.2.158
# Check `Cargo.lock` whether change to libc version was applied.
cargo check --target {solaris,apple,linux,...}

@larseggert
Copy link
Collaborator Author

@mxinden thanks, I guess pinning it worked.

@larseggert larseggert merged commit be512df into main Dec 17, 2024
29 of 31 checks passed
@larseggert larseggert deleted the feat-solaris branch December 17, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants