-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Solaris support #45
Conversation
b81523a
to
3ad6630
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 88.78% 86.28% -2.50%
==========================================
Files 5 5
Lines 517 554 +37
Branches 517 554 +37
==========================================
+ Hits 459 478 +19
- Misses 34 48 +14
- Partials 24 28 +4 ☔ View full report in Codecov by Sentry. |
Do we want this as part of 0.2.3? |
I don't see why not. Loosening the |
No, you're not missing anything. I thought including this might make landing 0.2.3 in gecko easier, due to the lift of the restriction on Will wait for @martinthomson to give this a review. |
Co-authored-by: Max Inden <mail@max-inden.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what my review is worth, this looks good to me.
@mxinden is there a way to test whether the |
@larseggert you should be able to run something along the lines of:
|
@mxinden thanks, I guess pinning it worked. |
Because
libc
on Solaris misses most of the needed symbols, this pulls them in viabindgen
also for the other BSDs. This has the side effect of removing the dependency on a relatively recentlibc
(= newer than what Gecko requires).Also some refactoring to the VM CI checks as I was adding Solaris support there.
Drop in coverage is mostly because
llvm-cov
is not available on Solaris.