-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light theme CSS file #2997
Add light theme CSS file #2997
Conversation
@@ -109,7 +109,7 @@ <h2>Join us.</h2> | |||
<div class="footer flex"> | |||
<div class="flex-col-3 mozilla"> | |||
<a href="https://mozilla.org/"> | |||
<img class="logo" src="static/img/moz-logo.svg" /> | |||
<div class="logo"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed in the DB as well.
Forgot to include changes to the |
See #2997 (comment). |
Did you give a try to the accessibility checks for contrast in Firefox devtools? The MOVE ALL buttons in locale selectors (e.g. at the end of the settings page) seem too light, and hard to read. Same for the CANCEL button. In general, when the text is Project header, completion chart, but also completion bar in the list of projects: the "incomplete" part uses a very dark gray like in the dark theme, and it feels strange. The |
c4d5a2f
to
8140b0d
Compare
The fxa landing page used by the add-on is completely borked. |
Thanks for pointing it out - looks like 0bb0752 wasn't deployed to stage for some reason. I re-deployed this branch, which also includes a few CSS fixes and a theme toggle in the profile menu in all views but the translate view. |
The page always uses dark theme for me? |
Correct. Dark theme is default and if you are not logged in we use the default. |
But I'm already logged in, and my profile is set to use the light theme. If I click projects I get light theme. |
Then this is out of scope of this issue - we should not be showing a Sign In page to logged in users. |
…date ~10 rarely used colors
d85278a
to
a10db9c
Compare
…o the Light theme and use them in the progress chart hover
…tion with font-weight: 300 [in /pontoon]
…tion with font-weight: 300 [in /translate]
Fix #2935. In addition to adding the light theme, this patch also includes consistency changes on the dark theme.
Note: after deployment, a small change is required to the homepage contents stored in the database, because a Mozilla logo in the footer has been moved from HTML to CSS. I've already done it on stage to where this patch is currently deployed.
How to test themes in Pontoon?
What pages to test?
Known blocking issues:
with font-weight: 300
(more)Known non-blocking issues:
Issues not related to this patch (i.e. issues to be filed):