Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore notification panel delay back to 2 seconds #3033

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Nov 23, 2023

Fix #3011.

During the development of the light theme, I needed the notification popup to be shown for a longer period than just 2 seconds. And I committed that change by mistake. 🤦

b97cbb7#diff-c0aa89be6ec58edea23eb616736c9bdf130d5ce3063749733db72e24c020e8c0R28

@mathjazz mathjazz requested a review from eemeli November 23, 2023 16:28
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 5E3 the modern choice for a delay like this? 😇

@mathjazz mathjazz merged commit ae74bc4 into mozilla:main Nov 23, 2023
4 checks passed
@mathjazz mathjazz deleted the 3011-restore-notification-delay branch November 23, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering the notification bar makes it stick for over 10 seconds, with no way to dismiss it
2 participants