Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Link in Comment Notifications #3049

Merged

Conversation

ayanaar
Copy link
Contributor

@ayanaar ayanaar commented Dec 13, 2023

Fixes #2538

This pull request introduces enhancements to the notification system, specifically addressing the issue reported in mozilla/pontoon#2538. It corrects the way notification verbs are displayed in scenarios where the associated strings have been deleted.

Changes:

  • Implemented a check to accurately determine when a notification's target is missing (accounting for null or undefined values).
  • Adjusted the notification verb phrasing to provide clearer context when the target string is absent, changing from "has added a comment in" to "has added a comment".

@ayanaar ayanaar requested a review from mathjazz December 13, 2023 03:22
@ayanaar ayanaar marked this pull request as ready for review December 13, 2023 19:02
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@mathjazz mathjazz merged commit 2cea74d into mozilla:main Dec 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing link in comment notifications when string gets deleted
2 participants