Add tests for the pontoon.insights module (#3015)

[potat0]

Fix #3015.

This is my first contribution to this project. Let me know if there are any improvements I can do. 

• Added tests for pontoon.insights module
• Added test for calling the endpoint without arguments and no data
• Added test with approved and rejected translations per month and assert that the translation quality percents match
• Ran make test
  • 
  • 
  • 

[mathjazz]

Nice work!

Only left a few comments to hopefully make the code slightly more manageable.

[potat0]

Thank you for the review! I'll try to get around to making changes this weekend.

[potat0]

Hi @mathjazz , let me know if there are any additional changes you would like to see.

[mathjazz]

Thanks for the update (and sorry for the slow response from my end!).

I only added a couple more comments.

Going forward, could you please just add commits with changes, rather than force-push? That way it'll be much easier to see what exactly has changed since the code has been looked at.

[potat0]

Hi @mathjazz . No problem. Sorry for missing moving the fixtures from test_pretranslate.py. Hopefully I got everything this time. I'll use normal commits going forward instead of force pushes.

[mathjazz]

Thanks for the update!

Please see the failing tests.

[mathjazz]

Please note that the pytest is still failing - we just introduced caching that causes it:
7bdcacc#diff-78a0f2e1d3a0a671add455c921328565557bfd1c242000b244fb2a9677a696bcR10

[potat0]

Thank you for pointing out the latest caching update. I was stumped why it was failing in ci/cd. After pulling and merging latest, I was able to reproduce the pytest failure occurring in the GitHub action. Clearing the cache prior to running the tests seems to fix it locally. I was looking into how to clear specific views out of the cache, but these solutions (https://stackoverflow.com/questions/2268417/expire-a-view-cache-in-django/2268583#2268583) are quite involved and could be brittle since they depend on the implementation within Django.

[mathjazz]

Thank you for pointing out the latest caching update. I was stumped why it was failing in ci/cd. After pulling and merging latest, I was able to reproduce the pytest failure occurring in the GitHub action. Clearing the cache prior to running the tests seems to fix it locally. I was looking into how to clear specific views out of the cache, but these solutions (https://stackoverflow.com/questions/2268417/expire-a-view-cache-in-django/2268583#2268583) are quite involved and could be brittle since they depend on the implementation within Django.

Nicely done!

Thank you for your contribution to Pontoon!