Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #550: fix building of container on MacOS #551

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix #550: fix building of container on MacOS #551

merged 5 commits into from
Feb 7, 2024

Conversation

leplatrem
Copy link
Contributor

Fix #550

@leplatrem leplatrem requested a review from a team as a code owner February 6, 2024 16:04
@leplatrem leplatrem added the bug Something isn't working label Feb 6, 2024
@leplatrem leplatrem requested a review from grahamalama February 7, 2024 13:16
grahamalama
grahamalama approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity:

The "main" fix here was updating the lockfile to pull in the wheel that prevented the container from being built on Apple Silicon MacOS. The other two changes were drive-bys (but still useful!).

@leplatrem leplatrem merged commit 507c930 into main Feb 7, 2024
7 checks passed
@leplatrem leplatrem deleted the 550-fix-macos-container branch February 7, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build container on Mac OS
2 participants
@leplatrem @grahamalama