Sign commit generated by github action for kinto-admin update #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
approved these changes
Feb 8, 2024
| echo "$LATEST_RELEASE" > kinto-admin/VERSION | ||
| SHA=$(git rev-parse $BRANCH_NAME:kinto-admin/VERSION) | ||
| CONTENT=$(base64 -i kinto-admin/VERSION) | ||
| gh api --method PUT /repos/:owner/:repo/contents/kinto-admin/VERSION \ |
There was a problem hiding this comment.
Are the :owner and :repo placeholders magically interpolated somehow?
There was a problem hiding this comment.
When running in an action, this context should be set for us automatically. You can set it locally by doing gh repo set-default inside a git repo and you will see something like:
gh repo set-default
Found only one known remote repo, mozilla/remote-settings on github.com.
✓ Set mozilla/remote-settings as the default repository for the current directory
If you're on a fork it'll ask you to pick which remote you want:
gh repo set-default
This command sets the default remote repository to use when querying the
GitHub API for the locally cloned repository.
gh uses the default repository for things like:
- viewing and creating pull requests
- viewing and creating issues
- viewing and creating releases
- working with GitHub Actions
- adding repository and environment secrets
? Which repository should be the default? [Use arrows to move, type to filter]
mozilla/remote-settings
> alexcottner/remote-settings
These merge fields fall into the magic category and I was going to hard-code them at first. But then this workflow isn't usable on forks, if the repo name ever changes, etc.
|
For posterity: this is related to #529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting our github action workflow that updates kinto-admin. Making the request over the github API should result in a signed commit.