Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #706: fix local server with new Autograph behaviour #707

Merged
merged 5 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
"filename": "docs/tutorial-local-server.rst",
"hashed_secret": "25ab86bed149ca6ca9c1c0d5db7c9a91388ddeab",
"is_verified": false,
"line_number": 101
"line_number": 99
}
],
"docs/tutorial-multi-signoff.rst": [
Expand Down
14 changes: 1 addition & 13 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
volumes:
db-data:
debug-mail:
autograph-certs:
attachments:
services:
db:
Expand All @@ -25,18 +24,8 @@ services:
platform: linux/amd64
image: mozilla/autograph
user: root
volumes:
- autograph-certs:/tmp/autograph

certchains:
image: httpd:2
volumes:
- autograph-certs:/usr/local/apache2/htdocs/
depends_on:
- autograph
ports:
- 9999:80

- 8000:8000
web:
build:
dockerfile: RemoteSettings.Dockerfile
Expand Down Expand Up @@ -70,7 +59,6 @@ services:
profiles: [browser-test]
depends_on:
- web
- certchains
environment:
- SERVER=http://web:8888/v1
- MAIL_DIR=/var/debug-mail/
Expand Down
10 changes: 7 additions & 3 deletions docs/tutorial-local-server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,13 @@ With Multi-signoff (advanced)

Using a different configuration, we can obtain a local instance that has proper authentication and multi-signoff that interacts with an `Autograph instance <https://github.com/mozilla-services/autograph/>`_ in order to sign the data, roughly like the STAGE server.

We will run the Autograph container in a separate terminal. Since Autograph generates the ``x5u`` certificate chains on startup, we will use a volume mounted on the same location, so that Firefox can download them at the same location as the native ``x5u`` URLs (Autograph will point ``x5u`` URLs to ``file:///tmp/attachments``).

.. code-block:: bash

mkdir -m 777 /tmp/attachments # world writable

.. code-block:: bash

docker run -v /tmp/attachments:/tmp/attachments \
docker run -p 8000:8000 \
--rm --name autograph mozilla/autograph

And run the Remote Settings server with a link to ``autograph`` container:
Expand Down Expand Up @@ -109,6 +107,12 @@ Unlike with *Simple Mode*, we'll need an ``admin`` user:
Prepare the client
------------------

The server will refer to ``http://autograph:8000/`` in the certificate chains URLs. Since the browser is going to have to fetch them, this line has to be added in the *hosts* file:

.. code-block:: bash

echo "127.0.0.1 autograph" >> /etc/hosts

The official way to point the client at another server is using the
`Remote Settings dev tools
<https://github.com/mozilla-extensions/remote-settings-devtools>`_. This
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/test_signer.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def canonical_json(records, last_modified):


async def verify_signature(records, timestamp, signature):
x5u = signature["x5u"].replace("file:///tmp/autograph/", "http://certchains/")
x5u = signature["x5u"]
serialized = canonical_json(records, timestamp).encode("utf-8")

async with aiohttp.ClientSession() as session:
Expand Down
Loading