Fix+augment testsuite, tighten up implementation

src/lib.rs

@@ -12,7 +12,6 @@ use validation_state::ValidationState;
 pub use crate::config::CliConfig;
 use crate::schemas::{validate_as_action, validate_as_workflow};
 #[cfg(not(feature = "js"))]
-use glob::glob;
 use serde_json::{Map, Value};
 
 #[cfg(feature = "js")]
@@ -196,7 +195,14 @@ fn validate_globs(globs: &serde_json::Value, path: &str, state: &mut ValidationS
 
     if let Some(globs) = globs.as_array() {
         for g in globs {
-            match glob(&g.as_str().unwrap().replace("!", "")) {
+            let glob = g.as_str().expect("glob to be a string");
+            let pattern = if glob.starts_with('!') {
+                glob.chars().skip(1).collect()
+            } else {
+                glob.to_string()
+            };
+
+            match glob::glob(&pattern) {
                 Ok(res) => {
                     if res.count() == 0 {
                         state.errors.push(ValidationError::NoFilesMatchingGlob {

test/003_successful_globs/glob.yml

@@ -4,7 +4,7 @@ on:
   push:
     paths:
       - 003_successful_globs/*
-      - !003_successful_globs/*
+      - '!003_successful_globs/*.json'
 
 defaults:
   run:

test/004a_failing_negative_glob/exitcode

@@ -0,0 +1 @@
+1

test/004a_failing_negative_glob/glob.yml

@@ -0,0 +1,24 @@
+name: Bad globs, no biscuit
+
+on:
+  push:
+    paths:
+      - '!004a_failing_negative_glob/*.txt'
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  glob:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup
+        uses: something/setup@v1
+
+      - name: Build
+        uses: something/build@v1

test/004a_failing_negative_glob/stderr

@@ -0,0 +1,18 @@
+Validation failed: ValidationState {
+    action_type: Some(
+        Workflow,
+    ),
+    file_path: Some(
+        "004a_failing_negative_glob/glob.yml",
+    ),
+    errors: [
+        NoFilesMatchingGlob {
+            code: "glob_not_matched",
+            detail: Some(
+                "Glob \"!004a_failing_negative_glob/*.txt\" in /on/push/paths does not match any files",
+            ),
+            path: "/on/push/paths",
+            title: "Glob does not match any files",
+        },
+    ],
+}

test/004a_failing_negative_glob/stdout

@@ -0,0 +1 @@
+Fatal error validating 004a_failing_negative_glob/glob.yml

test/004a_failing_negative_glob/validation_state.snap.json

@@ -0,0 +1,4 @@
+{
+  "actionType": "workflow",
+  "errors": []
+}