Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use language: rust in .pre-commit-hooks #79

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Nov 22, 2024

Closes #74.

I've tested this on my local system with:

  • Ubuntu 24.10.
  • pre-commit 0.8.0.
  • No manual install of Rust or action-validator. This means that pre-commit is bootstrapping rust and the repo.

Perhaps @andrewring or @glatterf42 (from the linked issue) could also experiment, or @mpalmer could indicate other checks/tests/additions in order for this to be ready to merge.

@mpalmer
Copy link
Owner

mpalmer commented Nov 22, 2024

Cool stuff! Thanks for the PR, I'll merge it as soon as the workflows give the 👍 .

@mpalmer mpalmer merged commit 56ba56b into mpalmer:main Nov 22, 2024
14 of 16 checks passed
@andrewring
Copy link

Confirmed, this fixes the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit hook should not require action-validator to be already installed or have an extra script
3 participants