Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix wasm-bindgen warning on nightly #80

Merged

Conversation

bcheidemann
Copy link
Contributor

Fixes #78

Explanation

When CI runs on nightly rust, with wasm-bindgen >= 0.2.93, the wasm_bindgen_unstable_test_coverage is reported as an unknown condition. This appears to be a bug in wasm-bindgen, but it should not affect action-validator. For now, we can statically declare the wasm_bindgen_unstable_test_coverage cfg as expected by adding the following to our Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] }

@mpalmer
Copy link
Owner

mpalmer commented Nov 25, 2024

QC's having a sook, but it's only a prettier failure, and I'm not going to get upset about that. Thanks for the fix!

@mpalmer mpalmer merged commit 3cc9912 into mpalmer:main Nov 25, 2024
15 of 16 checks passed
@bcheidemann
Copy link
Contributor Author

QC's having a sook, but it's only a prettier failure, and I'm not going to get upset about that. Thanks for the fix!

I just realised that this branch was behind main. Prettier errors seem to disappear on my local after pulling latest commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM / node.js support broken with Rust nightly
2 participants