Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell completion and manpage support #82

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chenrui333
Copy link

👋 add shell completion and manpage support

chenrui333 added a commit to Homebrew/formula-patches that referenced this pull request Dec 28, 2024
upstream pr ref, mpalmer/action-validator#82

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the feat-completion-manpage branch from e41a9d9 to 8d93f0a Compare December 28, 2024 19:47
@mpalmer
Copy link
Owner

mpalmer commented Dec 31, 2024

Well, this is pretty neat. I'm keen to get this in, but it'll be a while before I get the time to make it fit into the existing codebase, stylistically. If you can update the PR to suit, that'll mean I can just hit the Merge button.

@chenrui333
Copy link
Author

make sense, let me get the pipeline green.

@chenrui333 chenrui333 force-pushed the feat-completion-manpage branch 3 times, most recently from d787dd6 to 732e76e Compare January 1, 2025 18:24
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the feat-completion-manpage branch from 8d6f83b to d6850c8 Compare January 1, 2025 18:34
@chenrui333
Copy link
Author

@mpalmer should be good to go, validated via my fork, https://github.com/chenrui333/action-validator/actions/runs/12573319816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants