[RFC] rebase: always kill all running msys2 processes #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using powershell to find and kill all processes using the dll, we can ensure that the rebase will actually work.
|
Autorebase mostly need only for 32-bit MSYS2 that we not support anymore |
|
I just got an effed up runtime update caused by a lingering process. Maybe it should go in the thing that moves the dll instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using powershell to find and kill all processes using the dll, we can ensure that the rebase will actually work.
A bit of testing is needed with someone on Windows Vista. We should also maybe come up with a switch to disable killing, since the search takes time.