ccache: unset CI env variable before running cmake #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, I may be mistaken on that: https://github.com/msys2-arm/msys2-autobuild/blob/35ff0b71b62cde6288cee94b82979cfcc017d16b/msys2_autobuild/build.py#L106 shows it just removing variables whose names start with |
jeremyd2019
force-pushed
the
ccache-unset-ci
branch
from
3310e03 to
fdc8bf3
Compare
ccache's cmake files will turn on a "dev mode" if CI is set in the environment, turning on -Werror among other things. This was causing the build on i686 to fail due to a warning with fmt 11. We don't really want ccache's dev mode, so unset it explicitly.
jeremyd2019
force-pushed
the
ccache-unset-ci
branch
from
fdc8bf3 to
3e0f915
Compare
|
|
|
Yeah, that would probably work too, as would the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccache's cmake files will turn on a "dev mode" if CI is set in the environment, turning on -Werror among other things. This was causing the build on i686 to fail due to a warning with fmt 11. We don't really want ccache's dev mode, so unset it explicitly.