Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on the extras library #366

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

kajinamit
Copy link
Contributor

Replace the extras library by built-in items to reduce external dependency.

Note that extras.safe_hasattr was already removed[1] and should be removed.

[1] testing-cabal/extras@304c046

... because it was removed[1].

[1] testing-cabal/extras@304c046
... because it can be easily replaced by built-in items. This allows us
to remove dependency on the external library.
Copy link
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. Before I merge though I'll try to get the coverage ci job functional again.

@kajinamit
Copy link
Contributor Author

@mtreinish I wonder if I can help something to move this forward, since this has been kept for some time ?

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.65%. Comparing base (cb0a935) to head (aeebcff).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
stestr/testlist.py 50.00% 4 Missing ⚠️
stestr/subunit_runner/program.py 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   61.76%   61.65%   -0.11%     
==========================================
  Files          30       30              
  Lines        2605     2608       +3     
  Branches      402      402              
==========================================
- Hits         1609     1608       -1     
- Misses        877      881       +4     
  Partials      119      119              
Flag Coverage Δ
unittests 61.65% <50.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mtreinish mtreinish merged commit 1dd16b3 into mtreinish:main Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants