[docs] Fix vale errors #1151
Merged
[docs] Fix vale errors #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
mnajdova
approved these changes
Dec 17, 2024
github-actions
bot
added
PR: out-of-date
oliviertassinari
force-pushed
the
vale-fix
branch
from
deca2e5 to
eb27d67
Compare
github-actions
bot
removed
the
PR: out-of-date
Comment on lines
-76
to
+78
| JavaScript animation libraries such as [Motion](https://motion.dev) require control of the mounting and unmounting lifecycle of components. Most Base UI components are unmounted when hidden. These components usually provide the `keepMounted` prop to allow JavaScript animation libraries to take control. | ||
| JavaScript animation libraries such as [Motion](https://motion.dev) require control of the mounting and unmounting lifecycle of components. | ||
| Most Base UI components are unmounted when hidden. These components usually provide the `keepMounted` prop to allow JavaScript animation libraries to take control. |
There was a problem hiding this comment.
I'm breaking the sentences into multiple lines so future PR diffs will be easier to review. It should have no impact on the rendered page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the output of
vale sync && git ls-files | grep -h -E ".(mdx|md)$" | xargs vale --filter='.Level=="error"'.The root problem is mui/mui-public#226