Skip to content

Commit

Permalink
[infra] Fix for matrix array generation (#235)
Browse files Browse the repository at this point in the history
  • Loading branch information
michelengelen authored Nov 7, 2024
1 parent 008ae93 commit 1e3c890
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/prs_create-cherry-pick-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: needs.detect_cherry_pick_targets.outputs.targetBranches != ''
strategy:
matrix:
branch: ${{ needs.detect_cherry_pick_targets.outputs.targetBranches }}
branch: ${{ fromJSON(needs.detect_cherry_pick_targets.outputs.targetBranches) }}
permissions:
issues: write
pull-requests: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scripts/prs/detectTargetBranch.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = async ({ core, context, github }) => {
if (vBranchRegex.test(pr.head_ref)) {
// the branch this is coming from is a version branch, so the cherry-pick target should be master
core.info('>>> Head Ref is a version branch, setting `master` as target');
core.setOutput('TARGET_BRANCHES', 'master');
core.setOutput('TARGET_BRANCHES', ['master']);
return;
}

Expand All @@ -61,7 +61,7 @@ module.exports = async ({ core, context, github }) => {
});

// set the target branches as output to be used as an input for the next step
core.setOutput('TARGET_BRANCHES', targetLabels.join(','));
core.setOutput('TARGET_BRANCHES', targetLabels);
core.setOutput('LABELS', ['cherry-pick', ...otherLabels].join(','));
core.setOutput('REVIEWERS', reviewers.join(','));
} catch (error) {
Expand Down

0 comments on commit 1e3c890

Please sign in to comment.