Visual description #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as checking session and participation code with the server on load in the client side
…ion code and session key
|
I think we should handle this in a different way. When people visit the website without clicking on the email link, this is what they would see. The title and description at the top is generic to the system and should be visible at all times. Human-readable session identifiers or custom descriptions should make it in the UI elsewhere (though I'm not sure where). |
|
Addressed both issues and merged master into the branch:
|
…r tooltip lingers on
|
I just added fixes for temporary invalid cells and tooltip lingering when uploading a spreadsheet. |
frederickjansen
added a commit
that referenced
this pull request
Jul 10, 2017
* 'master' of github.com:multiparty/web-mpc: Add description of session (#39) # Conflicts: # client/script/client.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #16 and #38 bullet 2, as well as checking the session key and participation code with the server as soon as they are typed in. Error in validation are displayed in the same way as before (using the new fail-* spans).