-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the datetime extension #289
Conversation
Thank you for making this pull request. Did you know? You can try it on Binder: . Also, the version of ITables developed in this PR can be installed with
(this requires |
d55a2a2
to
6bd3585
Compare
6bd3585
to
b434c8b
Compare
@@ -20,6 +20,9 @@ import 'datatables.net-keytable-dt/css/keyTable.dataTables.min.css'; | |||
import 'datatables.net-rowgroup-dt'; | |||
import 'datatables.net-rowgroup-dt/css/rowGroup.dataTables.min.css'; | |||
|
|||
import DateTime from 'datatables.net-datetime'; | |||
import 'datatables.net-datetime/dist/dataTables.dateTime.min.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllanJard for the other extensions I usually find the .css
file in a css
folder, does it have to be different for this one?
Testing locally with this code almost works, e.g. we can display and filter the table
@AllanJard do I need to do something special to get rid of the |
b434c8b
to
4e91780
Compare
The problem is gone now with |
AWesome - good to hear :) |
7cefe16
to
8abc56a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 27 27
Lines 1191 1191
=======================================
Hits 1142 1142
Misses 49 49 ☔ View full report in Codecov by Sentry. |
8abc56a
to
c4127ec
Compare
required by SearchBuilder when displaying dates
c4127ec
to
47847ae
Compare
Will close #288