Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix max insurance setting not being enforced #283

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix: fix max insurance setting not being enforced #283

merged 3 commits into from
Jul 5, 2024

Conversation

GravendeelJochem
Copy link
Contributor

INT-531

EdieLemoine
EdieLemoine suggested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests missen, titel is niet goed

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Jun 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (2a80eca) to head (435994b).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #283      +/-   ##
============================================
- Coverage     96.19%   96.19%   -0.01%     
  Complexity     1636     1636              
============================================
  Files           307      307              
  Lines          5439     5438       -1     
============================================
- Hits           5232     5231       -1     
  Misses          207      207

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GravendeelJochem GravendeelJochem marked this pull request as ready for review June 27, 2024 14:22
@GravendeelJochem GravendeelJochem requested a review from a team as a code owner June 27, 2024 14:22
joerivanveen
joerivanveen requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Vanwege de verwarring zou ik in de tests de bedragen die achter het euro teken staan daadwerkelijk in euro’s noemen, voor de leesbaarheid.
  • Klopt deze story nu met de werking van de keuzes, cq zijn de keuzes die gemaakt (kunnen) worden nu al in centen?
  • Graag in de titel beschrijven (in gebiedende wijs) welk probleem je opgelost hebt.

@myparcel-bot myparcel-bot bot force-pushed the fix-insurance-calculator branch 2 times, most recently from 542aa49 to d1c1442 Compare June 28, 2024 13:41
@GravendeelJochem GravendeelJochem changed the title fix: maxInsuranceValue fix fix: fixed issue with max insurance setting Jul 2, 2024
@GravendeelJochem
Copy link
Contributor Author

  • Vanwege de verwarring zou ik in de tests de bedragen die achter het euro teken staan daadwerkelijk in euro’s noemen, voor de leesbaarheid.
  • Klopt deze story nu met de werking van de keuzes, cq zijn de keuzes die gemaakt (kunnen) worden nu al in centen?
  • Graag in de titel beschrijven (in gebiedende wijs) welk probleem je opgelost hebt.
  • Titel is aangepast
  • Ja de story klopt nog.

@GravendeelJochem GravendeelJochem changed the title fix: fixed issue with max insurance setting fix: fix maxinsurance setting did not work as a hard cutoff Jul 4, 2024
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Jul 4, 2024
@EdieLemoine EdieLemoine changed the title fix: fix maxinsurance setting did not work as a hard cutoff fix: fix max insurance setting not being enforced Jul 4, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix-insurance-calculator branch from 763a825 to 1ab94a1 Compare July 4, 2024 12:16
@myparcel-bot myparcel-bot bot force-pushed the fix-insurance-calculator branch from 1ab94a1 to 435994b Compare July 4, 2024 15:25
@joerivanveen joerivanveen added this pull request to the merge queue Jul 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 5, 2024
@GravendeelJochem
fix: fix max insurance setting not being enforced (#283)
8274288 
INT-531
@joerivanveen joerivanveen removed this pull request from the merge queue due to a manual request Jul 5, 2024
@joerivanveen joerivanveen added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 86a6b83 Jul 5, 2024
8 checks passed
@joerivanveen joerivanveen deleted the fix-insurance-calculator branch July 5, 2024 14:53
myparcel-bot bot added a commit that referenced this pull request Jul 5, 2024
@myparcel-bot
chore(release): 2.39.1 [skip ci]
8a4c194 
## [2.39.1](v2.39.0...v2.39.1) (2024-07-05)

### 🐛 Bug Fixes

* fix max insurance setting not being enforced ([#283](#283)) ([86a6b83](86a6b83))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Jul 5, 2024

🎉 This PR is included in version 2.39.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerivanveen joerivanveen joerivanveen approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

Assignees

@GravendeelJochem GravendeelJochem

Labels
approved (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GravendeelJochem @EdieLemoine @joerivanveen