Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): allow showing description with shipping method #285

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jul 4, 2024

  • Also fixed disabled shipping methods still being shown

@EdieLemoine EdieLemoine requested a review from a team as a code owner July 4, 2024 12:12
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (0979cb4) to head (3cccbb6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #285      +/-   ##
============================================
+ Coverage     96.15%   96.19%   +0.04%     
  Complexity     1636     1636              
============================================
  Files           307      307              
  Lines          5431     5439       +8     
============================================
+ Hits           5222     5232      +10     
+ Misses          209      207       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/hide-disabled-shipping-methods branch from 365b616 to 61b8091 Compare July 4, 2024 12:16
@EdieLemoine EdieLemoine changed the title fix(settings): do not show disabled shipping methods feat(settings): allow showing description with shipping method Jul 4, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jul 4, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 2a80eca Jul 4, 2024
12 of 13 checks passed
@EdieLemoine EdieLemoine deleted the fix/hide-disabled-shipping-methods branch July 4, 2024 15:24
myparcel-bot bot added a commit that referenced this pull request Jul 4, 2024
## [2.39.0](v2.38.1...v2.39.0) (2024-07-04)

### ✨ New Features

* **settings:** allow showing description with shipping method ([#285](#285)) ([2a80eca](2a80eca))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Jul 4, 2024

🎉 This PR is included in version 2.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants