Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Spotify Node): Fix issue with null values breaking the response #12080

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Dec 6, 2024

Summary

Fixes an issue with playlists returning null values if it is "Spotify managed"

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/spotify-api-broken/63642
https://linear.app/n8n/issue/NODE-2116/community-issue-spotify-integration-get-playlists-fails
Fixes #12026
Fixes #12241

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Spotify/Spotify.node.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Joffcom Joffcom marked this pull request as ready for review January 3, 2025 10:38
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the bug but still tested manually with the fix and it works 🎉
left a small comment

{
album_type: 'album',
total_tracks: 11,
available_markets: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you store the array in a variable and reuse it instead of having it repeated multiple times 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify Get Tracks error Spotify Integration - Get Playlists Fails
2 participants