Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow using Vector Stores directly as Tools #12311

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat: Allow using Vector Stores directly as Tools #12311

wants to merge 19 commits into from
+402 −43

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Dec 19, 2024 •
edited
Loading

Summary

Allow querying Vector stores directly as Tools

image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mutdmour mutdmour mentioned this pull request Dec 19, 2024
Closed
4 tasks
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.18033% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/components/Node/NodeCreator/Modes/NodesMode.vue 36.36% 14 Missing ⚠️
...ents/Node/NodeCreator/composables/useViewStacks.ts 0.00% 10 Missing ⚠️
...de/NodeCreator/composables/useActionsGeneration.ts 16.66% 5 Missing ⚠️
...nodes/vector_store/shared/createVectorStoreNode.ts 95.23% 1 Missing ⚠️
...editor-ui/src/components/Node/NodeCreator/utils.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mutdmour mutdmour requested a review from OlegIvaniv December 30, 2024 16:30
@mutdmour mutdmour marked this pull request as ready for review December 30, 2024 16:30
OlegIvaniv
OlegIvaniv previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, seems to be working as expected! Kudos for adding createVectorStoreNode tests 🙏

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jan 3, 2025 •
edited
Loading

n8n    Run #8567

Run Properties:  status check passed Passed #8567  •  git commit caf997227f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review ado-2878-2
Run status status check passed Passed #8567
Run duration 04m 51s
Commit git commit caf997227f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 485
View all changes introduced in this branch ↗︎

@mutdmour mutdmour requested a review from OlegIvaniv January 3, 2025 09:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

✅ All Cypress E2E specs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicardoE105 RicardoE105 RicardoE105 approved these changes

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @OlegIvaniv @RicardoE105