Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Update node to account for URL in credentials #12356

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 23, 2024

Summary

Missed this one in #12175

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2887/[n8n-nodes]-move-openai-base-url-option-to-credentials

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Update OpenAI node to account for URL in credentials fix(OpenAI): Update node to account for URL in credentials Dec 23, 2024
@RicardoE105 RicardoE105 changed the title fix(OpenAI): Update node to account for URL in credentials fix(OpenAI Node): Update node to account for URL in credentials Dec 23, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-langchain/nodes/vendors/OpenAi/transport/index.ts 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please add a unit test here? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants