feat(editor): Add free AI credits CTA #12365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the base branch from
master
to
expose-license-feature-flags-to-frontend
n8n-assistant
bot
added
n8n team
RicardoE105
changed the title
RicardoE105
changed the title
RicardoE105
commented
Dec 24, 2024
| @@ -1061,7 +1070,9 @@ function resetCredentialData(): void { | |||
| <InlineNameEdit | |||
| :model-value="credentialName" | |||
| :subtitle="credentialType ? credentialType.displayName : ''" | |||
| :readonly="!credentialPermissions.update || !credentialType" | |||
| :readonly=" | |||
There was a problem hiding this comment.
This prevents users from editing the credential name
RicardoE105
commented
Dec 24, 2024
| @@ -597,6 +602,10 @@ function scrollToBottom() { | |||
| } | |||
|
|
|||
| async function retestCredential() { | |||
| if (isEditingManagedCredential.value) { | |||
There was a problem hiding this comment.
Do not send the request as there is nothing to test on managed credentials
RicardoE105
commented
Dec 24, 2024
| @@ -235,7 +236,10 @@ watch(showOAuthSuccessBanner, (newValue, oldValue) => { | |||
| </script> | |||
|
|
|||
| <template> | |||
| <div> | |||
| <n8n-callout v-if="isManaged" theme="warning" icon="exclamation-triangle"> | |||
There was a problem hiding this comment.
Prevent user from seeing the credential values
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
mutdmour
reviewed
Dec 27, 2024
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
|
|
||
| (useSettingsStore as any).mockReturnValue({ |
There was a problem hiding this comment.
It would be type-safer to avoid using any here. You can find other examples of places where we have mocked the settings store, for example here packages/editor-ui/src/composables/useDebugInfo.test.ts
There was a problem hiding this comment.
Will address in a follow up PR
RicardoE105
force-pushed
the
expose-license-feature-flags-to-frontend
branch
from
7f40bd3 to
fdbc530
Compare
Base automatically changed from
expose-license-feature-flags-to-frontend
to
master
December 27, 2024 15:23
also validates that managed credentials cannot be edited
RicardoE105
force-pushed
the
ado-2994-n8n-fe-add-cta-to-generate-the-credits-in-the-users-instance-v2
branch
from
145007d to
e38df6f
Compare
mutdmour
approved these changes
Dec 27, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 42s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
484
|
| View all changes introduced in this branch ↗︎ | |
|
|
1 similar comment
|
|
…edits-in-the-users-instance-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on top of #12363
Demo: https://share.cleanshot.com/gcK464Kn
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2994/[n8n-fe]-add-cta-to-generate-the-credits-in-the-users-instance
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)