fix(Execute Workflow Node): Fallback to Passthrough explicitly to avoid exception (no-changelog) #12384
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
MiloradFilipovic
approved these changes
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
CharlieKolb
changed the title
|
|
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
subworkflowInputs_fallbackToPassthrough
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | Charlie Kolb |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
45-workflow-selector-parameter.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.
e2e/14-mapping.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data mapping > maps expressions from json view |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor fix to avoid caught exception that shows up in log. This happens if an outdated
Execute Workflow Triggeris selected in the workflow selection dropdown in aExecute WorkflownodeRelated Linear tickets, Github issues, and Community forum posts
n/a
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)